09:00:08 #startmeeting Sailfish OS CalDAV/CardDAV contributors meeting 09:00:08 Meeting started Mon Nov 13 09:00:08 2017 UTC. The chair is chriadam_. Information about MeetBot at http://wiki.merproject.org/wiki/Meetings. 09:00:08 Useful Commands: #action #agreed #help #info #idea #link #topic. 09:00:16 #link https://sailfishos.org/wiki/CalDAV_and_CardDAV_Community_Contributions#13.2F11.2F2017_Meeting 09:00:22 #topic Introductions 09:00:32 Please introduce yourself with #info name/nick 09:00:37 #info Chris Adams, developer at Jolla 09:01:03 #info Leif-Jöran Olsson, community 09:01:06 #info Damien Caliste, CalDAV plugin user :) 09:02:24 hi ljo, welcome 09:02:26 we'll wait another 6 or so minutes in case some people are running a bit late, then we'll continue with the agenda :-) 09:03:04 chrisadam_, thx, glad to be back 09:06:26 ok, let's continue with the agenda :-) 09:06:32 #topic Follow-up Agenda Items From Last Meeting 09:07:02 The PR from rubdos was reviewed 09:07:21 not sure whether that one can be progressed further at this stage, last I saw there were still some outstanding comments on that one 09:07:48 I raised the issue with Buteo Sync Plugins and translated error messages internally, the response was: 09:08:07 "untranslated strings belong to journal. we could add custom mechanism for plugins to communicate that a translation file needs to be loaded, or we start maintaining global error enum list that we keep updating with specific errors" 09:08:35 there were some more details (e.g., sync UI in settings vs recent errors in events view) 09:08:55 but the basic decision, from what I can tell, is that we need some mechanism to ensure that whatever error message we show to users, must be translated. 09:09:21 I don't know where that leaves us, with your proposal, dcaliste, my memory is fuzzy on the details 09:09:28 chriadam_, thanks for discussing it internally. Conclusion is sensible. 09:09:47 Did you have time to look at my proposition of nemo-qml-plugin-buteo? 09:10:05 It would help to understand what should be translated. 09:10:57 I will take a look at that one. Possibly we could ask the UI to load a particular translation catalogue on demand, if required. 09:11:19 #link https://git.merproject.org/dcaliste/nemo-qml-plugin-buteo 09:11:20 #action chriadam to review the nemo-qml-plugin-buteo proposal 09:12:19 other follow-up items, pvuorela and I did review (and merge) a variety of PRs from dcaliste and mardy, not sure whether some are still outstanding from last month, or whether the ones which are still open are new ones. 09:12:25 There is an example of UI (not made for UI design but to demonstrate what kind of info we have at hand) in examples/ 09:13:03 dcaliste Yes, those are nice 09:13:21 dcaliste: sounds comprehensive, thanks 09:13:40 were there any other follow up items since last meeting, or shall we continue with the rest of the agenda? 09:14:13 I think that pending MR are new ones indeed. 09:14:47 Sorry, one point: 09:15:03 I've looked at TODO specificities in CalDAV plugin. 09:15:44 hopefully not too many changes required there? 09:15:49 It is WIP, you can see in my todos branch: https://git.merproject.org/dcaliste/buteo-sync-plugin-caldav/tree/todos 09:15:55 Not too many changes indeed. 09:15:59 great 09:16:04 One in reader. 09:16:13 Some in incidencehandler. 09:16:20 And some in notebooksyncagent. 09:16:45 It's quite simple indeed, but when working on it I decided to revamp notebooksyncagent. 09:16:56 The part in reader is done and I've added a test. 09:17:14 ok, I will ask blam and pvuorela to review also, but hopefully we can get that one in quite soon. 09:17:17 The parts in incidencehandler and notebooksyncagent are waiting for revamp to be finished. 09:17:38 thanks 09:17:44 ok, let's continue with the rest of the agenda: 09:17:53 #topic MER#1836 - Reminders/alarms for synced all-day events don't work 09:18:01 dcaliste investigated and provided fixes for this one 09:18:12 those have been reviewed and merged, and tagged 09:18:23 however, I realised today that we've internally been having all sorts of CI / infra issues 09:18:35 so I have absolutely no idea at this point which packages have been promoted and which haven't 09:18:50 I need to check the repo build metadata 09:18:57 and potentially retrigger builds 09:19:05 anyway, thanks to dcaliste for fixing that one! 09:19:14 #topic MER#1827 - Thunderbird reminders are triggered again after upsync 09:19:20 this one I believe is still outstanding 09:19:34 dcaliste: there's a PR in caldav from you, is that the only one required to fix this, or is there also something elsewhere? 09:20:21 Only https://git.merproject.org/mer-core/buteo-sync-plugin-caldav/merge_requests/31 is useful to fix this (at least I think so). 09:20:44 ok, I'll review that this week 09:20:48 I've updated it a bit after pvuorela review. 09:21:01 great 09:21:04 If you're fine, I'll squash the review commits. 09:21:26 it LGTM last time I checked, so assume so 09:21:35 Ok. 09:21:43 #topic MER#1714 - isdn field added to phone numbers on upsync 09:22:13 same as always, this one is a good task for new contributors if you're interested in joining the effort. get in contact if you'd be interested :-) 09:22:20 #topic MER#1751 - main issue resolved, but some minor tasks here remain. 09:22:48 same as always, .eml can be treated as .vcf in some circumstances (if the content type is text/vcard) 09:23:01 again please get in touch if you'd be interested in helping with this issue 09:23:06 #topic Any Other Business? 09:23:32 dcaliste: I guess there are a variety of open PRs from you at the moment, can you list the Mer bug numbers for easy reference? 09:24:09 There is the new MER#1848, etag is not updated for all exceptions in recurring events. 09:25:19 there is MER#1835 to allow to retrieve events in a window time, so plugin is not deleting old or far in the future events. 09:25:53 This one should be discussed because it is adding a new mkcal API https://git.merproject.org/mer-core/mkcal/merge_requests/2 09:26:26 There is MER#1840, having non-interval schedule not working properly. 09:27:24 ok, thank you. I will investigate and review, hopefully this week. 09:27:26 I would like also to revamp notebooksyncagent. see my tidy branch: https://git.merproject.org/dcaliste/buteo-sync-plugin-caldav/tree/tidy 09:27:50 I will ask blam to take a look at that too 09:28:10 For the last one, I'm proposing a new test for the delta function, see https://git.merproject.org/mer-core/buteo-sync-plugin-caldav/merge_requests/32 09:28:18 blam has seen this one already. 09:28:51 To propose lmy tidy branch as a MR, I'm waiting for the delta test to enter and also the etag one. 09:29:03 etag: https://git.merproject.org/mer-core/buteo-sync-plugin-caldav/merge_requests/30 09:29:07 ok. I'll merge those this week 09:29:15 I need to check this ci/infra issue first 09:29:26 Sure. 09:29:52 as always, huge thanks for your big efforts on this. 09:30:28 anything else to discuss from anyone? 09:30:30 Do you think the current tested package on TJC will enter 2.1.4? Or it has been branched already? 09:30:35 dcaliste: no idea 09:30:42 again this comes back to the ci/infra thing 09:30:47 ;) Infra issue! 09:30:47 I need to check what got promoted 09:31:07 One last question: 09:31:45 I need to check but it seems that my issue of sailfish-updater killing my calendars on restart only trigger if I put interval update. 09:32:11 In that case, do you think it is using the SyncLog::lastSuccessfulSyncTime() function? 09:32:21 Like the plugin was doing previously? 09:32:44 what is sailfish-updater? 09:32:48 In that case, the erasing make sense, the updater don't find any succesful last sync date so decide to restart. 09:33:15 is that OS-update thing? 09:33:20 Yes. 09:33:39 I'm trying to find the MER bug I filled for this. 09:35:13 It is MER#1822 09:35:43 os-update stuff is being rewritten currently. under the hood it is a jolla-store-client managed set of packagekit transactions 09:35:55 I don't think it uses buteo at all, however I'm not too familiar with the internals 09:36:34 Maybe you remember, we discussed at one moment last month. On restart (not only retsrat after update) my calendars are erased may account migrated to a new id. 09:36:50 It is an issue in sailfish-accounts-tool 09:36:52 oh right 09:36:55 the migration thing 09:36:59 didn't I fix that? 09:37:37 I can't answer, sorry, because it is closed source part and I don't which version I'm actually on. 09:38:08 I got erase when updating to 2.1.3.7 by the way. 09:38:24 I didn't fix it 09:38:28 I had some notes about it 09:38:33 but didn't create MR. dang. 09:39:01 My point is just maybe to help worrowing reproduction. 09:39:25 If I don't have a successful last sync date in log, I get erased on any restart. 09:39:35 whereas if you do, it doesn't erase? 09:39:51 right 09:40:18 the core issue is still the migration of the account to a new account id (therefore guaranteeing that there won't be a successful previous sync in the log for that account) 09:40:20 It seems so. I didn't wanted to reproduce the erasal yet voluntarily to check hat my assumption is right! 09:40:51 indeed 09:40:55 But if I have a valid date in log and I restart, everything is fine. 09:41:02 #action chriadam to investigate MER#1822 again 09:41:14 I will look into it 09:41:21 sorry for letting that one slip off my radar 09:41:39 ok, if nothing else, I guess we can end the meeting :-) Thanks again to everyone for helping out. 09:41:52 Before I end, something folks might be interested in: https://github.com/sailfishos/sailfish-secrets 09:42:11 still heavily in development, expect lots of changes over the next couple of months I guess. 09:42:18 review/feedback greatly appreciated 09:42:48 we will be making some changes to the API and implementation to bring us closer to the XDG secrets draft 09:43:07 Interesting. Can it be used to store passwords ? 09:43:35 yes, but not just passwords. any generic data blob. especially, secret keys / authentication keys. 09:43:46 anyway, not related to caldav/carddav 09:43:46 Great for GPG also ;) 09:43:54 :-) 09:43:56 +1 09:44:08 thanks everyone, closing the meeting in 5 09:44:13 I'm going to use it for PDF passwords also. 09:44:19 ...4 09:44:26 ...3 09:44:32 A new PR for sailfish-office it has been a long time. 09:44:32 ...2 09:44:38 ...1 09:44:49 dcaliste: oh, ping me or pvuorela if there are outstanding PRs in office 09:44:59 #endmeeting